2004-08-13 Matthias Clasen * === Released 2.4.6 === * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_style_set): Don't install the settings_notify_cb from here, since it may be called before the first screen_changed signal, confusing the logic in gtk_file_chooser_screen_changed(). (#148803, Abel Daniel) * gtk/gtktreeview.c (gtk_tree_view_row_changed): Make it compile. Fri Aug 13 01:25:55 2004 Matthias Clasen * NEWS: Updates. Fri Aug 13 01:06:56 2004 Matthias Clasen * gtk/gtktreeview.c (gtk_tree_view_row_inserted): Make fixed height mode handle insertions. (#135955, Michael Vogt, testcase by Tim-Philipp Müller, fix by Pawel Salek) Thu Aug 12 23:52:12 2004 Matthias Clasen Fix #149547, Markus Lausser: * gtk/gtkcombobox.c (gtk_combo_box_size_allocate): * gtk/gtkcombobox.c (gtk_combo_box_size_request): Don't crash if size_request or size_allocate are called early. * gtk/gtkcombobox.c (gtk_combo_box_size_allocate): Protect against being allocated too small. Thu Aug 12 23:18:03 2004 Matthias Clasen * gtk/gtkhandlebox.c: Remove an accidentally added include. 2004-08-12 Matthias Clasen * gtk/gtkaction.c (gtk_action_new): Fix the doc comment to generate valid XML. Thu Aug 12 02:20:54 2004 Matthias Clasen * NEWS: Updates Thu Aug 12 00:07:15 2004 Matthias Clasen * gtk/gtkaction.c (gtk_action_new): Link to information about allowed action names. (#149620, David Malcolm) 2004-08-11 Federico Mena Quintero Merged from HEAD: Fix #149422, #143457: * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_should_respond): Rewrite to take the current focus into account, the contents of the save entry, and the last focus for the shortcuts list. (switch_to_selected_folder): We don't need an assertion on the action here. Wed Aug 11 19:17:28 2004 Matthias Clasen * gtk/gtktreeview.c (gtk_tree_view_maybe_begin_dragging_row): Don't start a drag if the treeview is only a drag destination. (#149836, Pawel Salek) 2004-08-11 Kjartan Maraas * configure.in: Added nb to ALL_LINGUAS. Mon Aug 9 00:28:56 2004 Matthias Clasen * gtk/gtkicontheme.c (load_svg_at_size): Don't leak the file contents. 2004-08-07 Tor Lillqvist * gdk/win32/gdkkeys-win32.c (update_keymap): Don't hardcode mapping of VK_DECIMAL to GDK_KP_Decimal. Instead, let ToAsciiEx() map it to what's printed on the keypad decimal key for the current input locale (keyboard layout). (#149404) * gdk/win32/gdkevents-win32.c (handle_configure_event, gdk_event_translate:WM_WINDOWPOSCHANGED): Add _gdk_offset_{x,y} to top-level window coordinates, not just in generated events. (#148526, Robert Ögren) Merge from HEAD: * gdk/win32/gdkwindow-win32.c (gdk_window_new): Backward compatibility for GDK_WINDOW_TEMP, GDK_INPUT_ONLY. (#148702, Hans Breuer) Sat Aug 7 01:26:08 2004 Matthias Clasen Make the column drag code a bit more robust (still scary, though). (#106992, Christian Biere) * gtk/gtktreeview.c (_gtk_tree_view_column_start_drag): Assert that cur_reorder is NULL here. * gtk/gtktreeview.c (gtk_tree_view_button_release_drag_column): Reset cur_reorder to NULL, and only hide drag_highlight_window if it exists. 2004-08-06 Federico Mena Quintero Merged from HEAD: Fix #144232: * gtk/gtkfilechooserdefault.c (save_widgets_create): Use a GtkFileChooserEntry for the file name, rather than a GtkEntry. (update_chooser_entry): Set the contents of the file chooser entry rather than the plain entry's. (gtk_file_chooser_default_set_current_folder): Set the new folder on the save entry. (gtk_file_chooser_default_set_current_name): Set the name on the file chooser entry. (check_save_entry): Use the file chooser entry rather than the plain entry. * gtk/gtkfilechooserentry.c (_gtk_file_chooser_entry_set_base_folder): Call gtk_file_chooser_entry_changed() so that we recompute the current folder based on the new base folder. 2004-08-06 Matthias Clasen * gtk/gtktreeview.c (gtk_tree_view_move_cursor_page_up_down): Fix an off-by-one error. (#141809, Markku Vire) 2004-07-28 Robert Ögren * gdk/win32/gdkinput-win32.c (_gdk_input_other_event): Set x_root and y_root in button and motion events from the tablet. (#148715) Tue Aug 3 20:03:33 2004 Matthias Clasen * gtk/gtkuimanager.c (get_node): Make gtk_ui_manager_add_ui() accept paths with a leading "/ui". (#149077, David Malcolm) Tue Aug 3 18:38:40 2004 Matthias Clasen * gtk/gtktreemodelfilter.c: Correct the return type of gtk_tree_model_filter_get_flags(). (#149195, Morten Welinder) Tue Aug 3 18:16:55 2004 Matthias Clasen Fix #149191, reported by Morten Welinder: * gtk/gtkmain.c: Include gtkclipboard.h, * gtk/gtkwidget.h: Declare _gtk_widget_grab_notify, not _gtk_widget_emit_grab_notify. Tue Aug 3 01:30:40 2004 Matthias Clasen * gtk/gtkcombobox.c (gtk_combo_box_relayout_item): Optimize for the case that row_column and col_column are unset. (#148868, Lorenzo Gil Sánchez) Mon Aug 2 02:07:43 2004 Matthias Clasen * gtk/gtkentrycompletion.c (_gtk_entry_completion_popdown): Don't steal the pointer grab from the context menu of the entry. (#148686, Christian Persch) Mon Aug 2 01:02:57 2004 Matthias Clasen * gdk/x11/gdkevents-x11.c (gdk_check_wm_state_changed): (gdk_check_wm_desktop_changed): Add missing error traps. (#149011, Thomas Leonard) Mon Aug 2 00:12:16 2004 Matthias Clasen * gtk/gtkentry.c (gtk_entry_class_init): (gtk_entry_get_alignment): (gtk_entry_set_alignment): Document the xalign property and its getter and setter as 2.4 additions. (#148978, Axel Simon) Mon Aug 2 00:11:31 2004 Matthias Clasen * gtk/gtkuimanager.c (gtk_ui_manager_class_init): * gtk/gtkactiongroup.c (gtk_action_group_class_init): Use canonical signal names in doc comments, since gtk-doc won't pick up signal docs with underscores. Sat Jul 31 01:13:01 2004 Matthias Clasen * gtk/gtkwindow.c: * gtk/gtkentry.c: * gtk/gtkaction.c: Use the canonical form of signal names after "notify::". Otherwise, no notification arrives. GObject should have a warning for that, really. (#148879, Lorenzo Gil Sánchez) Sat Jul 31 00:42:08 2004 Matthias Clasen * gdk/x11/gdkwindow-x11.c (gdk_window_set_keep_below): * gdk/x11/gdkwindow-x11.c (gdk_window_set_keep_above): Don't set both states at once. (#148789, Matthew Garret) Fri Jul 30 02:21:41 2004 Matthias Clasen * gtk/gtkentrycompletion.c (_gtk_entry_completion_resize_popup): Fix the positioning of the popup. 2004-07-28 Federico Mena Quintero Merged from HEAD: * gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault): Store signal IDs in gulongs, not guints! (gtk_file_chooser_default_hierarchy_changed): We now monitor the focus widget on our toplevel to know which widget was last focused at the time our "should_respond" method gets called. (shortcuts_activate_selected): New helper function. (shortcuts_get_selected): New helper function. (remove_selected_bookmarks): Use shortcuts_get_selected(). (bookmarks_check_remove_sensitivity): Likewise. (shortcuts_reorder): Likewise. (shortcuts_activate_iter): Renamed from shortcuts_activate_item(). Activate by iter, not by item number. (save_folder_combo_changed_cb): Use shortcuts_activate_iter(). (shortcuts_row_activated_cb): Likewise. (gtk_file_chooser_default_should_respond): If the last focused widget on the toplevel was the shortcuts list, activate the selected shortcut. 2004-07-28 Matthias Clasen * gdk/linux-fb/gdkprivate-fb.h: Make the fb backend compile against current freetype. (#148558, Nicolas Deves) * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_background): Fix prototype mismatch. (#148589, Nicolas Deves) * gtk/gtkuimanager.c: Warning fixes. Fri Jul 23 11:00:17 2004 Matthias Clasen * gtk/gtktextbtree.c (_gtk_text_line_previous_could_contain_tag): Don't iterate too far up. (#147965, Olivier Sessink) Thu Jul 22 01:21:28 2004 Matthias Clasen * gtk/gtkfontsel.c (gtk_font_selection_init): Add additional accessability relations. (#141804, Padraig O'Briain) Wed Jul 21 22:54:33 2004 Matthias Clasen * gtk/gtkcomboboxentry.c (gtk_combo_box_entry_new_text): Don't leak the list store. (#148135, Crispin Flowerday) Wed Jul 21 22:47:28 2004 Matthias Clasen * gtk/gtkcombobox.c (gtk_combo_box_new_text): Don't leak the list store. (#148134, Crispin Flowerday) Wed Jul 21 22:35:47 2004 Matthias Clasen * gtk/gtkcombobox.c (gtk_combo_box_destroy): Don't leak the menu. (#148110, Tommi Komulainen) Wed Jul 21 22:24:10 2004 Matthias Clasen * gtk/gtkcellview.c (gtk_cell_view_finalize): Don't leak tree model and tree row reference. (#148125, Crispin Flowerday) Wed Jul 21 22:17:06 2004 Matthias Clasen * tests/testcombo.c (main): Don't leak models. (#148128, Tommi Komulainen) Wed Jul 21 21:26:08 2004 Matthias Clasen * gtk/gtkviewport.c (viewport_set_adjustment): Don't leak the adjustments. (#148089, Tommi Komulainen) Wed Jul 21 21:20:21 2004 Matthias Clasen * gtk/gtktreeview.c (gtk_tree_view_destroy): Don't leak the adjustments. (#148073, Tommi Komulainen) Wed Jul 21 21:04:50 2004 Matthias Clasen * gtk/gtktoolbar.c (gtk_toolbar_finalize): Don't leak the arrow. (#148064, Tommi Komulainen) Tue Jul 20 22:26:29 2004 Matthias Clasen * gtk/gtkfilechooserutils.h: * gtk/gtktoolbutton.c: * gtk/gtktoolbar.c: * gtk/gtkicontheme.c: * gtk/gtkcalendar.c: * demos/gtk-demo/ui_manager.c: * demos/gtk-demo/appwindow.c: Remove trailing commas from enumerations. (#148035) 2004-07-20 Matthias Clasen * gtk/gtkuimanager.c (update_node, free_node): Ref an sink all proxies, so that we can properly clean up floating proxies which the app didn't adopt. (#147926, Tommi Komulainen) Tue Jul 20 00:49:43 2004 Matthias Clasen * gtk/gtktreeview.c (gtk_tree_view_button_press): Set drag_pos before grabbing the focus, since we may reenter into gtk_tree_view_motion_resize_column() which requires drag_pos to be set. (#147913, Guilherme Salgado, patch by John Finlay) Mon Jul 19 23:51:50 2004 Matthias Clasen * gtk/gtktreeview.c (gtk_tree_view_enter_notify): Don't use uninitialized node pointer. (#147911, Peter Zelezny) Thu Jul 15 22:19:40 2004 Matthias Clasen Fix #60128, #58307, #144706: * gtk/gtkstyle.c (gtk_style_real_copy): Handle references to bg_pixmaps properly. (gtk_style_real_unrealize): Don't keep dangling references to the bg_pixmaps. (gtk_style_attach): Split the loop into two loops, first looking for a matching style, then for an empty one. (gtk_style_finalize): (gtk_style_duplicate): Add comments explaining the handling of style->styles. Thu Jul 15 20:31:28 2004 Matthias Clasen * gtk/gtkspinbutton.c (start_spinning): Install the timeout before changing the value, so that a ::value_changed handler has a chance to remove it. (#122427, Elke Meier) 2004-07-15 Matthias Clasen * gtk/gtkmenu.c (gtk_menu_set_tearoff_state): Don't reparent back to menu->toplevel if it is already gone because we're shutting down. (#147656, John Cupitt) 2004-07-14 Federico Mena Quintero Merged from HEAD: Fix #126295: * gtk/gtktreeview.c (gtk_tree_view_bin_expose): Draw a focus indicator along the edge of the bin_window when the tree is empty. (grab_focus_and_unset_draw_keyfocus): New helper function. (gtk_tree_view_button_press): Remove a bit of superfluous code. Use the helper function to save on duplicated code. (gtk_tree_view_button_press): Grab the focus if the tree is empty. (gtk_tree_view_focus): Allow focusing into an empty tree. 2004-07-14 Federico Mena Quintero Merged from HEAD: Fix #144405, patch by Padraig O'Briain : * gtk/gtkfilechooserdefault.c (shortcuts_list_create): Set the accessible object name for the tree view. (create_file_list): Likewise. Tue Jul 13 21:55:15 2004 Matthias Clasen * gtk/gtkicontheme.c (free_unthemed_icon): Don't leak no_svg_filename. (#147399, Kjartan Maraas) 2004-07-13 Federico Mena Quintero Merged from HEAD: * gtk/gtkfilechooserdefault.c (shortcuts_activate_volume): Set a busy cursor while mounting the volume. Also, ref the chooser while mounting, as we may re-enter. Fixes #139376. 2004-07-13 Matthias Clasen * gtk/gtkmain.h: Add gtk_parse_args(). Its public API. (#147476, Owen Taylor) * gtk/gtkcombobox.c (gtk_combo_box_popdown): Don't crash if unrealized. 2004-07-12 Matthias Clasen * gtk/gtkrc.c (_gtk_rc_init): Apply the gtk-default-menu-item-style to cell view menu items as well. (#147405, John Cupitt) * gtk/gtkcombobox.c (gtk_combo_box_menu_key_press): Pop down first. (#147399, John Cupitt) Sat Jul 10 23:35:13 2004 Matthias Clasen * gtk/gtkentry.c (paste_received): Make middle-button pasting work as expected inside the entry. (#116789, Scott Bronson) Sat Jul 10 22:19:08 2004 Matthias Clasen * gtk/gtktextbuffer.c (gtk_text_buffer_select_range): Update clipboards. (#142805, Mikael Hallendal)