2015-02-05 Martyn Russell Release 1.3.3 Merge tag 'fix-discno' of git://git.meterriblecrew.net/spacefrogg/tracker Fixed parsing disc number in vorbis comments. This fixes: https://bugzilla.gnome.org/show_bug.cgi?id=681698 * tag 'fix-discno' of git://git.meterriblecrew.net/spacefrogg/tracker: Fixed parsing disc number in Vorbis comments. 2015-02-05 Mingxiang Lin tracker-extract: Add width and height information to BMP extractor https://bugzilla.gnome.org/show_bug.cgi?id=741109 2015-01-29 Michael Raitza Fixed parsing disc number in Vorbis comments. De facto standard for storing the disc number is the comment tag `DISCNUMBER' and not `DISCNO'. Tag `DISCNO' still takes priority to not break the current behaviour. Fixed for both, Vorbis comments in vorbis and FLAC files. Fixing: https://bugzilla.gnome.org/show_bug.cgi?id=681698 2015-01-26 Yanko Kaneti Mechanically adjust for libmediaart-2.0 https://bugzilla.gnome.org/show_bug.cgi?id=743250 2015-01-17 Dimitris Spingos Updated Greek translation 2015-01-13 Debarshi Ray libtracker-miner: Restrict the amount of data that is logged for errors SPARQL update strings can be very long if the entire text of a document is being stored. Dumping these huge strings to the log eats up disk space and makes them harder to follow. However, often, the occurence of such an error indicates a broken extractor. In those cases, knowing part of the SPARQL can help in identifying the file that triggered the error. Usually the "nie:plainTextContent" property is the last one in the string, so we truncate the error messages at the first occurance of this property to achieve the best of both worlds. https://bugzilla.gnome.org/show_bug.cgi?id=735406 2015-01-12 Fran Dieguez Updated Galician translations 2015-01-08 Inaki Larranaga Murgoitio Updated Basque language 2015-01-05 Debarshi Ray miners: Detect locale changes only when the miner could be constructed https://bugzilla.gnome.org/show_bug.cgi?id=742391 2014-12-31 Sam Thursfield miner-fs: Give clearer warning when XDG user dirs are unconfigured If Tracker can't resolve special dirs like &DOCUMENTS to real path names, it now gives a warning like this: (tracker-miner-fs:7207): Tracker-WARNING **: Unable to get XDG user directory path for special directory &DOCUMENTS. Ignoring this location. Previously (since commit 5f06c134f4f6da02027c813322e13c220b51cd0a) the user would see this rather more scary output: (tracker-miner-fs:6046): GLib-GIO-CRITICAL **: g_file_new_for_path: assertion 'path != NULL' failed (tracker-miner-fs:6046): GLib-GIO-CRITICAL **: g_file_equal: assertion 'G_IS_FILE (file1)' failed (tracker-miner-fs:6046): GLib-GObject-CRITICAL **: g_object_unref: assertion 'G_IS_OBJECT (object)' failed This situation is rare (you need to manually change or break XDG_CONFIG_HOME to really see it) but it's always nice to avoid showing critical errors! sandbox: Fix to use new-style config files The config file format changed in commit 2b53cd5d3aaf046c413fd4afb188c16d7e611f48. sandbox: Change how content directory is specified Firstly, allow specifying multiple --content options, and allow specifying --content-non-recursive if you really want as well. Also, don't generate an XDG user directories config. It seems a bit weird to be doing this and setting each directory to the same location. 2014-12-29 Tim Lunn libtracker-extract: fix logic in guarantee title from file https://bugzilla.gnome.org/show_bug.cgi?id=742035 libtracker-extract: fix crash when running unit tests media_art_process is not set when running tracker-extract-info tests https://bugzilla.gnome.org/show_bug.cgi?id=742035 2014-12-27 Martin Kampas Use g_unix_signal_add() for signal handlers Identified by functional-tests/17-ontology-changes timeouting randomly. Documentation for g_unix_signal_source_new() explains why it is not safe to call g_main_loop_quit() from a regular UNIX signal handler. Intentionally removed the (main_loop != NULL) tests - this cannot happen. https://bugzilla.gnome.org/show_bug.cgi?id=739234 2014-12-27 Brian Nitz tracker-needle: Missing accessible label names on tracker-needle widgets https://bugzilla.gnome.org/show_bug.cgi?id=663687 2014-12-26 Sam Thursfield Merge branch 'sam/functional-test-60x-fixes' functional-tests: Fix and improve 601-applications-sync This test adds data that would normally be added by the FS miner. In order for the resource to be correctly deleted when the file is removed, it must set nie:isStoredAs correctly. functional-tests: Consolidate and clean up 600-applications-camera Merge branch 'sam/functional-test-50x-fixes' functional-tests: Remove another guarantee-metadata dependency writeback: Improve error when writeback fails due to missing module functional-tests: Fix 'not a directory' error in writeback tests This makes the following error less likely, and clearer when it does occur: (tracker-miner-fs:28886): Tracker-WARNING **: Could not open directory 'file:///home/sam/tracker-tests/writeback': Not a directory Merge branch 'sam/functional-test-40x-fixes' functional-tests: Don't require 'guarantee-metadata' for some tests Tests shouldn't break just because --enable-guarantee-metadata is not specified at configure time. This feature is off by default so we shouldn't depend on it. See GB#733536. tracker-extract: More helpful error when missing GStreamer plugins If extraction with GstDiscoverer fails due to lack of a plugin, we can display exactly what plugin was missing rather than just giving a generic error. This makes it a bit easier to fix the problem. Merge branch 'sam/functional-test-30x-fixes' Fix max_depth parameter causing contents of a directory to be ignored Since commit 41e6ab84e7a540b20f8173c2bbaee11de6ef381f, the contents of directories listed in 'index-single-directories' is be ignored. The directory itself appears in the store but the contents do not. The intention of passing max_depth=1 if TRACKER_DIRECTORY_FLAG_RECURSE is false must be to prevent unnecessarily processing any subdirectory nodes that are hanging around in the TrackerFileSystem. However, the documentation of g_node_traverse says: "If depth is 1, only the root is visited. If depth is 2, the root and its children are visited. And so on." Thus, we must pass max_depth+1 to the tracker_file_system_traverse() function so that the files in the directory are processed as well as the directory itself. See also: 243c97fa96a2f6b19bce1acf26946d1a516a0a1c which introduced the 'max_depth' parameter as a way of reducing the number of GFile objects in memory at the same time during crawling. functional-tests: Isolate 3xx-miner tests from each other Rather than running all the tests in one environment, create a new environment for each test. Although it's slower this way, it's just too hard to debug test failures when the tests can interfere with each other. I also made them all use the same 'minertest' base class. functional-tests: Improve stopping of child processes Instead of using `tracker daemon --kill=miners` to stop the miners, use the Python 'subprocess' module. This ensures only the correct miner process gets killed if more than one is running. (I also found that `tracker daemon --kill-miners` was hanging my system, which was the real motivation for fixing this, but I have no idea why that happened). If a process fails to terminate after we sent it TERM, it now gets sent KILL. Previously the test would wait forever. functional-tests: Many fixes to 3xx-miner tests All 3xx tests should now pass except 2 of the 310-fts-indexing tests. functional-tests: Add await_property_changed() method This allows detecting when a file move has been done, and probably other useful things too. 2014-12-24 Christian Kirbach Updated German translation 2014-12-22 Philip Withnall libtracker-sparql: Document requirement to escape constructed queries Bring SQL injection to the front of people’s minds when using the APIs so that hopefully they don’t write injectable code. https://bugzilla.gnome.org/show_bug.cgi?id=741777 2014-12-22 Sam Thursfield functional-tests: Fix bad calls to `tracker daemon` command 2014-12-22 Philip Van Hoof Use crawler's max_depth param of start in file_system_traverse 2014-12-20 Martin Kampas miner-fs: Remove unused argument is_new https://bugzilla.gnome.org/show_bug.cgi?id=678986 miner-fs: Fix tracking file move Identified by MinerCrawlTest::test_07_move_from_monitored_to_monitored (300-miner-basic-ops.py) In item_move() it fails to get source_iri, does not check it's validity and uses it in the DELETE expression of the SPARQL query constructed there. Broken since d836f00 (libtracker-miner: Store iri transiently as GFile qdata) - tracker_file_notifier_get_file_iri() is added 'force' argument and (wrapped with lookup_file_urn) passed force=FALSE from item_move(). This call then fails for regular files because only directories are cached once crawling has completed as stated in the comment in finish_current_directory() in libtracker-miner/tracker-file-notifier.c. https://bugzilla.gnome.org/show_bug.cgi?id=678986 2014-12-20 Balázs Úr Updated Hungarian translation 2014-12-18 Daniel Mustieles Updated Spanish translation 2014-12-15 Martyn Russell libtracker-miner: Finished documenting public APIs Only 2 left, mainly because they're a NOP or don't work currently and need fixing. tracker-miner-fs: On error, return correct defaults for config This covers tracker_config_get_crawling_interval() and _get_removable_days_threshold() which were returning just 0. libtracker-miner: Improve documentation for tracker_miner_fs_{s|g}et_throttle() libtracker-miner: Renamed internal define TRACKER_MAX_TIMEOUT_INTERVAL Use _CRAWLER_ in there so we know where it comes from. 2014-12-15 Marek Černocký Updated Czech translation 2014-12-15 Rafael Ferreira Updated Brazilian Portuguese translation 2014-12-12 Martyn Russell build: Make life easier with autogen by adding args if none are provided This patch does 3 things: 1. Fix the --with-enca (which should have been --enable-enca and was failing) 2. If JHBUILD_PREFIX is set, use that when no args are given 3. If no args are given, use the make distcheck default args in place This will ensure documentation and unit tests are build most of the time and things don't break so often :)